Skip to content

fix(#1841): do not refresh on buffer events when not a file buffer#1843

Merged
alex-courtis merged 1 commit into
masterfrom
1841-do-not-reload-open-buffers-when-not-a-file-buffer
Dec 19, 2022
Merged

fix(#1841): do not refresh on buffer events when not a file buffer#1843
alex-courtis merged 1 commit into
masterfrom
1841-do-not-reload-open-buffers-when-not-a-file-buffer

Conversation

@alex-courtis

@alex-courtis alex-courtis commented Dec 19, 2022

Copy link
Copy Markdown
Member

fixes #1841

vim.fn.filereadable is expensive. Empty buftype should be good enough to detect whether it's a buffer that we can show/highlight.

Follows hotfix 4fc74ca

Follows on from #1830

@chomosuke chomosuke left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Haven't had time to dig into #1841 but this does make sense and looks like something that would fix it.

@alex-courtis alex-courtis merged commit e14c289 into master Dec 19, 2022
@alex-courtis

Copy link
Copy Markdown
Member Author

Haven't had time to dig into #1841

No worries at all; there's no hurry.

@chomosuke

Copy link
Copy Markdown
Collaborator

1 min too late but update: I just tested this PR and it does work!

@gegoune gegoune deleted the 1841-do-not-reload-open-buffers-when-not-a-file-buffer branch December 19, 2022 12:13
@alex-courtis

Copy link
Copy Markdown
Member Author

1 min too late but update: I just tested this PR and it does work!

Thanks @chomosuke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when generating CMake files.

2 participants